Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Mahdi Cypress Tests for Login #55

Merged
merged 32 commits into from
Dec 6, 2023
Merged

Add: Mahdi Cypress Tests for Login #55

merged 32 commits into from
Dec 6, 2023

Conversation

MahdiBaghbani
Copy link
Member

No description provided.

@MahdiBaghbani MahdiBaghbani changed the title add: Mahdi Cypress Tests for Login Add: Mahdi Cypress Tests for Login Dec 5, 2023
@MahdiBaghbani MahdiBaghbani self-assigned this Dec 5, 2023
@soltanireza65
Copy link
Contributor

Nice and clean
Just a suggestion:
you may also need to initiate a local in-mem storage to store tokens to pass to Ajax calls on login callback (I know you are not calling Ajax calls yet)

@MahdiBaghbani MahdiBaghbani merged commit 03a4668 into ocm Dec 6, 2023
4 checks passed
@MahdiBaghbani MahdiBaghbani deleted the ocm-mahdi-edition branch December 15, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants