Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Codespaces is now OK with Docker build kit #69

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

michielbdejong
Copy link
Member

No description provided.

@michielbdejong
Copy link
Member Author

See https://github.com/orgs/community/discussions/38878#discussioncomment-8062176 - the docker version in gh codespaces has been updated and the weirdness no longer occurs, so we can now safely use docker build kit everywhere.

Copy link
Member

@MahdiBaghbani MahdiBaghbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we need to read from an argument to decide whether to use buildkit or not, in case anything like the GitHub issue appears in the future

Copy link
Member

@MahdiBaghbani MahdiBaghbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @michielbdejong

@MahdiBaghbani MahdiBaghbani merged commit fb75cb0 into main Jan 9, 2024
4 checks passed
@MahdiBaghbani MahdiBaghbani deleted the use-buildkit branch February 28, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants