Skip to content

Commit

Permalink
Fix broken make pylint (#66)
Browse files Browse the repository at this point in the history
We now stop if any linting fails thereby failing the job if any fail.
Previously the exit code for the job would be "0" if the last linting
succeeded.

Fixes #65
  • Loading branch information
SeanTAllen authored Aug 29, 2023
1 parent bca4309 commit 9bcc2be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ push: build
pylint: build $(PYTHON_COMMANDS)
$(foreach file, $(notdir $(PYTHON_COMMANDS)), \
echo "Linting $(file)"; \
docker run --entrypoint pylint --rm "ghcr.io/${IMAGE}:latest" /commands/$(file); \
docker run --entrypoint pylint --rm "ghcr.io/${IMAGE}:latest" /commands/$(file) || exit 1; \
)

.PHONY: push

0 comments on commit 9bcc2be

Please sign in to comment.