Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed syntax error in update-action-to-use-docker-image-to-run-action #64

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fixed syntax error in update-action-to-use-docker-image-to-run-action #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .release-notes/fix-broken.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Fixed syntax error in `update-action-to-use-docker-image-to-run-action`

It turns out our CI linting would show green for code that had failed linting. That is a bad setup. In the process, the last release had a syntax error in it.

We've fixed that.
4 changes: 2 additions & 2 deletions scripts/update-action-to-use-docker-image-to-run-action
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@ if 'REGISTRY' in os.environ:
}

registry = os.environ['REGISTRY']
if registry in registries
if registry in registries:
registry = registries[registry]
else
else:
print(ERROR + registry + " isn't a supported REGISTRY. Exiting." + ENDC)
sys.exit(1)

Expand Down
Loading