Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use Rust 1.80; drop once_cell #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshuamegnauth54
Copy link

libcosmic already requires Rust 1.80.

@bbb651
Copy link
Contributor

bbb651 commented Sep 9, 2024

Was just about to do that after dropping it in my app xD

I don't think adding MSRV is necessary, since it's a binary crate and not a library, and it'll already fail on libcosmic on <1.80 regardless. And if someone didn't add it they might not know or remember to update it, especially with libcosmic updates that bump it, and imo an incorrect MSRV is worst than no MSRV at all

@joshuamegnauth54
Copy link
Author

Good point. I'll remove the MSRV since it doesn't really matter here.

`libcosmic` already requires Rust 1.80 so `once_cell` isn't required
anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants