warning: taken reference of right operand --> cosmic-app-list/cosmic-app-list-config/src/lib.rs:45:63 | 45 | if let Some(pos) = self.favorites.iter().position(|e| e == &id) { | ^^^^^--- | | | help: use the right value directly: `id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default

warning: this `if` statement can be collapsed --> cosmic-applet-audio/src/mouse_area.rs:301:9 | 301 | / if !state.is_out_of_bounds { 302 | | if widget 303 | | .on_mouse_enter 304 | | .as_ref() ... | 315 | | } 316 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 301 ~ if !state.is_out_of_bounds && widget 302 + .on_mouse_enter 303 + .as_ref() 304 + .or(widget.on_mouse_exit.as_ref()) 305 + .is_some() { 306 + if let Event::Mouse(mouse::Event::CursorMoved { .. }) = event { 307 + state.is_out_of_bounds = true; 308 + if let Some(message) = widget.on_mouse_exit.as_ref() { 309 + shell.publish(message.clone()); 310 + } 311 + return event::Status::Captured; 312 + } 313 + } |

warning: unused imports: `Rectangle` and `protocols::xdg::shell::client::xdg_positioner::Anchor` --> cosmic-applet-audio/src/lib.rs:16:38 | 16 | cctk::sctk::reexports::{calloop, protocols::xdg::shell::client::xdg_positioner::Anchor}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 21 | window, Alignment, Length, Limits, Rectangle, Subscription, | ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

warning: this `else { if .. }` block can be collapsed --> cosmic-applet-network/src/app.rs:720:16 | 720 | } else { | ________________^ 721 | | if self.nm_state.wifi_enabled { 722 | | content = content.push(padded_control(divider::horizontal::default())); 723 | | for known in &self.nm_state.known_access_points { ... | 813 | | } 814 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 720 ~ } else if self.nm_state.wifi_enabled { 721 + content = content.push(padded_control(divider::horizontal::default())); 722 + for known in &self.nm_state.known_access_points { 723 + let mut btn_content = Vec::with_capacity(2); 724 + let ssid = text::body(&known.ssid).width(Length::Fill); 725 + if known.working { 726 + btn_content.push( 727 + icon::from_name("network-wireless-acquiring-symbolic") 728 + .size(24) 729 + .symbolic(true) 730 + .into(), 731 + ); 732 + btn_content.push(ssid.into()); 733 + btn_content.push( 734 + icon::from_name("process-working-symbolic") 735 + .size(24) 736 + .symbolic(true) 737 + .into(), 738 + ); 739 + } else if matches!(known.state, DeviceState::Unavailable) { 740 + btn_content.push( 741 + icon::from_name("network-wireless-disconnected-symbolic") 742 + .size(24) 743 + .symbolic(true) 744 + .into(), 745 + ); 746 + btn_content.push(ssid.into()); 747 + } else { 748 + btn_content.push( 749 + icon::from_name(wifi_icon(known.strength)) 750 + .size(24) 751 + .symbolic(true) 752 + .into(), 753 + ); 754 + btn_content.push(ssid.into()); 755 + } 756 + 757 + if self.failed_known_ssids.contains(&known.ssid) { 758 + btn_content.push( 759 + cosmic::widget::button::icon( 760 + from_name("view-refresh-symbolic").size(16), 761 + ) 762 + .icon_size(16) 763 + .on_press(Message::ResetFailedKnownSsid(known.ssid.clone())) 764 + .into(), 765 + ) 766 + } 767 + 768 + let mut btn = menu_button( 769 + Row::with_children(btn_content) 770 + .align_items(Alignment::Center) 771 + .spacing(8), 772 + ); 773 + btn = match known.state { 774 + DeviceState::Failed 775 + | DeviceState::Unknown 776 + | DeviceState::Unmanaged 777 + | DeviceState::Disconnected 778 + | DeviceState::NeedAuth => { 779 + btn.on_press(Message::ActivateKnownWifi(known.ssid.clone())) 780 + } 781 + DeviceState::Activated => { 782 + btn.on_press(Message::Disconnect(known.ssid.clone())) 783 + } 784 + _ => btn, 785 + }; 786 + known_wifi.push(Element::from(row![btn].align_items(Alignment::Center))); 787 + } 788 + 789 + le

warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:422:16 | 422 | IterateErr(IterateResult), | ---------- ^^^^^^^^^^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 422 | IterateErr(()), | ~~

warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:423:16 | 423 | ContextErr(pulse::context::State), | ---------- ^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 423 | ContextErr(()), | ~~

warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:424:18 | 424 | OperationErr(pulse::operation::State), | ------------ ^^^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 424 | OperationErr(()), | ~~

warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:425:11 | 425 | PAErr(PAErr), | ----- ^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 425 | PAErr(()), | ~~

warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:427:10 | 427 | Misc(&'a str), | ---- ^^^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 427 | Misc(()), | ~~