Skip to content

chore: update fde

chore: update fde #982

Triggered via pull request September 5, 2024 23:54
Status Success
Total duration 2m 38s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
taken reference of right operand: cosmic-app-list/cosmic-app-list-config/src/lib.rs#L45
warning: taken reference of right operand --> cosmic-app-list/cosmic-app-list-config/src/lib.rs:45:63 | 45 | if let Some(pos) = self.favorites.iter().position(|e| e == &id) { | ^^^^^--- | | | help: use the right value directly: `id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default
this `if` statement can be collapsed: cosmic-applet-audio/src/mouse_area.rs#L301
warning: this `if` statement can be collapsed --> cosmic-applet-audio/src/mouse_area.rs:301:9 | 301 | / if !state.is_out_of_bounds { 302 | | if widget 303 | | .on_mouse_enter 304 | | .as_ref() ... | 315 | | } 316 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 301 ~ if !state.is_out_of_bounds && widget 302 + .on_mouse_enter 303 + .as_ref() 304 + .or(widget.on_mouse_exit.as_ref()) 305 + .is_some() { 306 + if let Event::Mouse(mouse::Event::CursorMoved { .. }) = event { 307 + state.is_out_of_bounds = true; 308 + if let Some(message) = widget.on_mouse_exit.as_ref() { 309 + shell.publish(message.clone()); 310 + } 311 + return event::Status::Captured; 312 + } 313 + } |
unused imports: `Rectangle` and `protocols::xdg::shell::client::xdg_positioner::Anchor`: cosmic-applet-audio/src/lib.rs#L16
warning: unused imports: `Rectangle` and `protocols::xdg::shell::client::xdg_positioner::Anchor` --> cosmic-applet-audio/src/lib.rs:16:38 | 16 | cctk::sctk::reexports::{calloop, protocols::xdg::shell::client::xdg_positioner::Anchor}, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ... 21 | window, Alignment, Length, Limits, Rectangle, Subscription, | ^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default
field `0` is never read: cosmic-app-list/src/app.rs#L372
warning: field `0` is never read --> cosmic-app-list/src/app.rs:372:17 | 372 | RemovedSeat(WlSeat), | ----------- ^^^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 372 | RemovedSeat(()), | ~~
this function has too many arguments (9/7): cosmic-app-list/src/app.rs#L164
warning: this function has too many arguments (9/7) --> cosmic-app-list/src/app.rs:164:5 | 164 | / fn as_icon( 165 | | &self, 166 | | applet: &Context, 167 | | rectangle_tracker: Option<&RectangleTracker<DockItemId>>, ... | 173 | | window_id: window::Id, 174 | | ) -> Element<'_, Message> { | |_____________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
useless conversion to the same type: `u32`: cosmic-app-list/src/app.rs#L278
warning: useless conversion to the same type: `u32` --> cosmic-app-list/src/app.rs:278:57 | 278 | Some(Message::TopLevelListPopup((*id).into(), window_id)) | ^^^^^^^^^^^^ help: consider removing `.into()`: `(*id)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default
useless conversion to the same type: `u32`: cosmic-app-list/src/app.rs#L283
warning: useless conversion to the same type: `u32` --> cosmic-app-list/src/app.rs:283:46 | 283 | .on_right_release(Message::Popup((*id).into(), window_id)) | ^^^^^^^^^^^^ help: consider removing `.into()`: `(*id)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `u32`: cosmic-app-list/src/app.rs#L286
warning: useless conversion to the same type: `u32` --> cosmic-app-list/src/app.rs:286:55 | 286 | .unwrap_or_else(|| Message::Popup((*id).into(), window_id)) | ^^^^^^^^^^^^ help: consider removing `.into()`: `(*id)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `u32`: cosmic-app-list/src/app.rs#L296
warning: useless conversion to the same type: `u32` --> cosmic-app-list/src/app.rs:296:52 | 296 | .on_drag(|_, _| Message::StartDrag((*id).into())) | ^^^^^^^^^^^^ help: consider removing `.into()`: `(*id)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
field `0` is never read: cosmic-applet-audio/src/pulse.rs#L422
warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:422:16 | 422 | IterateErr(IterateResult), | ---------- ^^^^^^^^^^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 422 | IterateErr(()), | ~~