warning: taken reference of right operand --> cosmic-app-list/cosmic-app-list-config/src/lib.rs:45:63 | 45 | if let Some(pos) = self.favorites.iter().position(|e| e == &id) { | ^^^^^--- | | | help: use the right value directly: `id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref = note: `#[warn(clippy::op_ref)]` on by default

warning: this `if` statement can be collapsed --> cosmic-applet-audio/src/mouse_area.rs:301:9 | 301 | / if !state.is_out_of_bounds { 302 | | if widget 303 | | .on_mouse_enter 304 | | .as_ref() ... | 315 | | } 316 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `#[warn(clippy::collapsible_if)]` on by default help: collapse nested if block | 301 ~ if !state.is_out_of_bounds && widget 302 + .on_mouse_enter 303 + .as_ref() 304 + .or(widget.on_mouse_exit.as_ref()) 305 + .is_some() { 306 + if let Event::Mouse(mouse::Event::CursorMoved { .. }) = event { 307 + state.is_out_of_bounds = true; 308 + if let Some(message) = widget.on_mouse_exit.as_ref() { 309 + shell.publish(message.clone()); 310 + } 311 + return event::Status::Captured; 312 + } 313 + } |

warning: variant `OpenSettings` is never constructed --> cosmic-applet-notifications/src/lib.rs:95:5 | 83 | enum Message { | ------- variant in this enum ... 95 | OpenSettings, | ^^^^^^^^^^^^ | = note: `Message` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis = note: `#[warn(dead_code)]` on by default

warning: this function has too many arguments (9/7) --> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1 | 24 | // #[proxy( 25 | || interface = "org.freedesktop.Notifications", 26 | || default_service = "org.freedesktop.Notifications", 27 | || default_path = "/org/freedesktop/Notifications" 28 | || )] | ||__- in this procedural macro expansion ... | 49 | | expire_timeout: i32, 50 | | ) -> zbus::Result<u32>; | |___________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default = note: this warning originates in the attribute macro `proxy` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: this function has too many arguments (9/7) --> cosmic-applet-notifications/src/subscriptions/freedesktop_proxy.rs:24:1 | 24 | / #[proxy( 25 | | interface = "org.freedesktop.Notifications", 26 | | default_service = "org.freedesktop.Notifications", 27 | | default_path = "/org/freedesktop/Notifications" 28 | | )] | |__^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: this warning originates in the attribute macro `proxy` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: called `map(..).flatten()` on `Iterator` --> cosmic-applet-notifications/src/lib.rs:298:47 | 298 | for n in self.cards.drain(..).map(|n| n.1).flatten() { | ^^^^^^^^^^^^^^^^^^^^^^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|n| n.1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten = note: `#[warn(clippy::map_flatten)]` on by default

warning: useless conversion to the same type: `std::string::String` --> cosmic-applet-notifications/src/lib.rs:384:36 | 384 | let no_notifications = String::from(fl!("no-notifications")); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `fl!("no-notifications")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `#[warn(clippy::useless_conversion)]` on by default

warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:454:16 | 454 | IterateErr(IterateResult), | ---------- ^^^^^^^^^^^^^ | | | field in this variant | = note: `#[warn(dead_code)]` on by default help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 454 | IterateErr(()), | ~~

warning: field `0` is never read --> cosmic-applet-audio/src/pulse.rs:455:16 | 455 | ContextErr(pulse::context::State), | ---------- ^^^^^^^^^^^^^^^^^^^^^ | | | field in this variant | help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field | 455 | ContextErr(()), | ~~