fix(time): Update applet timezone on change #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: pop-os#582 The chrono crate caches the local timezone but doesn't update it. This makes sense because it'd be inefficient to constantly evaluate the local timezone. Instead of using the local timezone, this patch changes the applet to use a fixed offset internally which is updated if the external timezone changes.
mmstick
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #582
The
chronocrate caches the local timezone but doesn't update it. This makes sense because it'd be inefficient to constantly evaluate the local timezone.Instead of using the local timezone, this patch changes the applet to use a fixed offset internally which is updated if the external timezone changes.
I added two new dependencies to the
timeapplet.chrono, and the documentation recommends using it for situations like this.