Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve bolt admin find #125

Merged
merged 8 commits into from
Feb 10, 2024
Merged

Further improve bolt admin find #125

merged 8 commits into from
Feb 10, 2024

Conversation

rymiel
Copy link
Collaborator

@rymiel rymiel commented Feb 9, 2024

This moves the find command results to use the new Time utility class added in #123. This provides more readable relative time, and also provides the exact timestamp on hover.

This change also modifies the "click to teleport" to be more obvious by adding a hover event, and also expands the clickable area to the whole line.

This change also patches a bug where click teleports would not work for built-in world. This is because Bukkit uses names different from the vanilla game. For example, what Bukkit calls "world", minecraft calls "overworld". Thus, a different method is needed to obtain the format that works for minecraft commands.

image
image

This moves the find command results to use the new Time utility class
added in #123. This provides more readable relative time, and also
provides the exact timestamp on hover.

This change also modifies the "click to teleport" to be more obvious by
adding a hover event, and also expands the clickable area to the whole
line.

This change also patches a bug where click teleports would not work for
built-in world. This is because Bukkit uses names different from the
vanilla game. For example, what Bukkit calls "world", minecraft calls
"overworld". Thus, a different method is needed to obtain the format
that works for minecraft commands.
@rymiel rymiel added bug Something isn't working enhancement New feature or request labels Feb 9, 2024
@rymiel rymiel requested a review from pop4959 February 9, 2024 13:30
@pop4959 pop4959 merged commit accd063 into pop4959:master Feb 10, 2024
1 check passed
@rymiel rymiel deleted the improve-find branch February 10, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants