Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio playback improvement #268

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

kumama
Copy link

@kumama kumama commented Oct 24, 2014

Hi, popcormmix,

As reported long long time ago( #28 ), a problem about audio channel change during playback.

Some container format doesn't care about audio channels, so we should check decoded(codec output) audio format.(As ffmpeg do) And this audio format change is minor change, so we don't need close -> open codec.

I know this patch is very rough and need some improvement.

May I ask you reviewing this patch?

@popcornmix
Copy link
Owner

Do you have a test file that has a changing number of audio channels?

@kumama
Copy link
Author

kumama commented Oct 26, 2014

  • about fdk-aac

Watching video with omxplayer I noticed we can hear some cycle noises during playback sometimes. It's not always and not big. Some month ago I can't stand this noise, check video file using vlc(on my mac) but it's normal.So I debug omxplayer but noting is here. Then I convert aac to pcm using ffmpeg and visualize.

Using ffmpeg internal aac decoder ->

ffmpeg-internal-aacdecoder

Using fdk-aac decoder ->

libfdk-aacdecoder

obviously ffmpeg's internal aac decoder generate cyclic noise.so I trying to use fdk-aac.The noise is gone.

BUT, some reason, I think it should not become default in this time.

  • ffmpeg's fdk-aac wrapper's implementation have missing part(e.g.: channel change ... ),
  • fdk-aac license
  • Need work Makefile.ffmpeg

CPU usage is fair. when compile fdk-aac with same compiler optimization option.

@kumama
Copy link
Author

kumama commented Oct 26, 2014

I have the file that has a changing number of audio channels.
Please mail me. ( kuwana at kuwana.org ), I'll send you a URL.

Buffer allocation is annoying thing.I know the normal way is freeing buffer and re-allocate appropriate size. but the buffer is tunneled, so some buffer is using by another component and can't free.so at this time allocate max size of buffer for further channel change.

kumama referenced this pull request in kumama/omxplayer Oct 29, 2014
@kumama
Copy link
Author

kumama commented Oct 31, 2014

I made channel change sample.
http://kumama.org/omxplayer/channel_transition.ts

@Ruffio
Copy link

Ruffio commented Apr 28, 2016

@kumama will you fix the conflicts?

@Ruffio
Copy link

Ruffio commented Jan 7, 2017

@popcornmix Can this be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants