Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2020_Nagele_Caribbean #19

Merged
merged 9 commits into from
Dec 17, 2024
Merged

Add 2020_Nagele_Caribbean #19

merged 9 commits into from
Dec 17, 2024

Conversation

TCLamnidis
Copy link
Member

@TCLamnidis TCLamnidis commented Aug 8, 2024

Adds package 2020_Nagele_Caribbean

Linked to poseidon-framework/minotaur-recipes#46

New packages added to the minotaur archive are always published in version 1.0.0. This means that nay and all changes made to the package during the review process, should only bump the Minor or Patch version of the package.

PR checklist:

  • This package contains a BibTex file.
  • If this package already exists in the community archive:
    • The information from the community archive was used to fill-in empty janno fields.
    • The commands used for the fill-in and any tool versions are kept track of in the README file.
    • The BibTex key used for the citation is identical to that in the corresponding package in the community archive.
    • The DOI in the BibTex file is identical to the one used in the corresponding package in the comunity archive.
  • Country information is also present in the Country_ISO column.
  • Add any additional contributors to POSEIDON.yml

Once the Pull Request has passed the review process, ensure the package version is bumped once more before publishing with:

trident rectify -d <package_dir> --logText 'Bump version for release' --packageVersion Major --checksumAll

@TCLamnidis TCLamnidis changed the title Add 2020_Nagele_Carribbean Add 2020_Nagele_Carribbean Aug 12, 2024
@TCLamnidis TCLamnidis changed the title Add 2020_Nagele_Carribbean Add 2020_Nagele_Caribbean Aug 12, 2024
@TCLamnidis
Copy link
Member Author

I can see that some individuals have genetic relationships to other individuals in the Group_Name column from the community archive.
@KathrinNaegele Would be awesome if you could have a look at the janno file and transfer the Kinship information to the Relation_* columns instead.

@TCLamnidis TCLamnidis added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Aug 12, 2024
@TCLamnidis
Copy link
Member Author

Updated kinship information after cross-referencing with @KathrinNaegele.

@TCLamnidis TCLamnidis added the Final review needed This PR needs its final review before going live label Dec 11, 2024
Copy link
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me!

@TCLamnidis TCLamnidis merged commit 8996c44 into main Dec 17, 2024
1 check passed
@TCLamnidis TCLamnidis deleted the 2020_Nagele_Caribbean branch December 17, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Final review needed This PR needs its final review before going live
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants