Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 2023_OlaldeCarrion_Roman #6

Merged
merged 11 commits into from
Apr 18, 2024
Merged

add 2023_OlaldeCarrion_Roman #6

merged 11 commits into from
Apr 18, 2024

Conversation

TCLamnidis
Copy link
Member

Adds package 2023_OlaldeCarrion_Roman

Linked to poseidon-framework/minotaur-recipes#12

@TCLamnidis TCLamnidis marked this pull request as draft March 12, 2024 12:25
@TCLamnidis
Copy link
Member Author

This is the initial Minotaur package for 2023_OlaldeCarrion_Roman. I would now need @PCQuilis and/or @danimfernandes to fill in missing meta-information in the janno file, like:

  • Group_Name
  • Alternative_IDs
  • Relation_To
  • Relation_Degree
  • Relation_Type
  • Relation_Note
  • Collection_ID
  • Country
  • Country_ISO
  • Location
  • Site
  • Latitude
  • Longitude
  • Date_Type
  • Date_C14_Labnr
  • Date_C14_Uncal_BP
  • Date_C14_Uncal_BP_Err
  • Date_BC_AD_Start
  • Date_BC_AD_Median
  • Date_BC_AD_Stop
  • Date_Note
  • MT_Haplogroup
  • Y_Haplogroup
  • Source_Tissue
  • Primary_Contact
  • Publication
  • Note
  • Keywords

@TCLamnidis TCLamnidis marked this pull request as ready for review April 5, 2024 07:40
@stschiff
Copy link
Member

OK, is this actually happening, is someone preparing the meta-data? Or shall we accept this package without the meta-data for now and fill it in later?

@danimfernandes
Copy link

I told Thiseas I'd do it but didn't manage to get to it yet. I'll look into it tomorrow!

@PCQuilis
Copy link

Sorry I didn't have any time to look into this. Will you manage @danimfernandes ?

@danimfernandes
Copy link

Here is the file! I hope it's fine. I also filled in the Genetic Sex column, even though it was not in the list above. I tried to follow the details from www.poseidon-adna.org/#/janno_details for filling each column.

2023_OlaldeCarrion_Roman.zip

@TCLamnidis
Copy link
Member Author

One thing to note:
for I15501 we get

RateX RateY RateErrX RateErrY
0.865 0.454 0.0406 0.0359

Which would suggest an aneuploidy, but in the paper they specifically checked and find no evidence for one (see S2, Table 11)

@nevrome
Copy link
Member

nevrome commented Apr 17, 2024

Looks all good. I only saw two things:

  1. The description field in the .janno file is not filled yet. My suggestion: "139 Balkan individuals dated to the Roman, Migration, and Early Medieval Period (1st millennium CE)"
  2. As always the package version should be changed to v1.0.0 before merging.

@TCLamnidis
Copy link
Member Author

TCLamnidis commented Apr 18, 2024

I have been adding the title of the publication as the description so far, so I did the same here.

After talking with @PCQuilis and @BenRohrlach, and double-checking the result for I15501, I have marked the individual as XXY in the Notes field.

@nevrome have another look. when i get approval I can merge this in :)

@TCLamnidis TCLamnidis merged commit 3a8c6d9 into main Apr 18, 2024
1 check passed
@TCLamnidis TCLamnidis deleted the 2023_OlaldeCarrion_Roman branch April 24, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants