Deal with less common file hyperlinks on Windows #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
commented
Mar 8, 2024
| @@ -56,6 +57,11 @@ export const OutputRun = (props: OutputRunProps) => { | |||
| return url; | |||
| } | |||
|
|
|||
| // a hack that, at least, pinpoints the problem / solution | |||
| if (platform.isWindows) { | |||
| url = url.replace(/\\/g, '/').replace(/file:\/\/(?!\/)/g, 'file:///'); | |||
There was a problem hiding this comment.
Example of a broken before link and a working after link:
file://D:\\Users\\jenny\\source\\repos\\glue\\tests\\testthat\\test-glue.R
file:///D:/Users/jenny/source/repos/glue/tests/testthat/test-glue.R
softwarenerd
approved these changes
Mar 11, 2024
jennybc
force-pushed
the
file-hyperlink-fixup
branch
from
31df356
to
1506419
Compare
jennybc
changed the title
softwarenerd
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2413
I give more context in #2413 but the TL;DR is that Positron does need to make a special allowance for the current file hyperlinks produced by the cli R package on Windows.
There is a path towards having cli emit more conventional hyperlinks, which Positron will opt in to once that's possible. Changes in the cli package are constrained by the need to also not break file hyperlinks on Windows in RStudio.