Skip to content

Commit

Permalink
Add narwals integration cmd (#1729)
Browse files Browse the repository at this point in the history
Co-authored-by: Barret Schloerke <[email protected]>
  • Loading branch information
karangattu and schloerke authored Oct 10, 2024
1 parent 81a4192 commit 3f120ea
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 0 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/pytest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -242,3 +242,18 @@ jobs:
name: "playright-examples-${{ runner.os }}-${{ matrix.python-version }}-results"
path: test-results/
retention-days: 5

test-narwhals-integration:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Setup py-shiny
id: install
uses: ./.github/py-shiny/setup
- name: Run test
env:
UV_SYSTEM_PYTHON: 1
run: |
make test-narwhals-integration
7 changes: 7 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ SUB_FILE:=
PYTEST_BROWSERS:= --browser webkit --browser firefox --browser chromium
PYTEST_DEPLOYS_BROWSERS:= --browser chromium


# Full test path to playwright tests
TEST_FILE:=tests/playwright/$(SUB_FILE)
# Default `make` values that shouldn't be directly used; (Use `TEST_FILE` instead!)
Expand Down Expand Up @@ -247,3 +248,9 @@ upgrade-html-deps: FORCE ## Upgrade Shiny's HTMLDependencies
exit 1; \
fi
@scripts/htmlDependencies.R

test-narwhals-integration: FORCE
@echo "-------- Install py-shiny ----------"
$(MAKE) ci-install-deps
@echo "-------- Running py-shiny tests ----------"
$(MAKE) test playwright TEST_FILE="tests/playwright/shiny/components/data_frame" PYTEST_BROWSERS="--browser chromium"

0 comments on commit 3f120ea

Please sign in to comment.