Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(theme): Branded theming via brand_yml #1743

Merged
merged 83 commits into from
Oct 25, 2024
Merged

feat(theme): Branded theming via brand_yml #1743

merged 83 commits into from
Oct 25, 2024

Commits on Oct 21, 2024

  1. feat: initial BrandTheme

    @gadenbuie
    gadenbuie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    f0b3464 View commit details
    Browse the repository at this point in the history

  2. feat: rename ThemeBrand

    @gadenbuie
    gadenbuie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    730af5c View commit details
    Browse the repository at this point in the history

  3. feat: Add _brand*.yml to default reload includes

    @gadenbuie
    gadenbuie committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    b73470f View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. feat(Theme): Add from_brand() method

    @gadenbuie
    gadenbuie committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ef936ea View commit details
    Browse the repository at this point in the history

  2. docs: Add brand-yml to interlinks inventories

    @gadenbuie
    gadenbuie committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9ebf4a5 View commit details
    Browse the repository at this point in the history

  3. chore: add brand_yml to dev dependencies too

    @gadenbuie
    gadenbuie committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    9fe9714 View commit details
    Browse the repository at this point in the history

  4. chore(Theme): Rename method _html_dependencies

    @gadenbuie
    gadenbuie committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3943ebc View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. feat: get fonts dependency from brand.typography

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    669e08a View commit details
    Browse the repository at this point in the history

  2. chore: clean up code

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    263ee07 View commit details
    Browse the repository at this point in the history

  3. feat: Apply brand.color.palette to bootstrap color map

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    6035788 View commit details
    Browse the repository at this point in the history

  4. fix: Use Bootstrap major version

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    3184691 View commit details
    Browse the repository at this point in the history

  5. chore: Add todo comments

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    137cc4c View commit details
    Browse the repository at this point in the history

  6. refactor: Move ThemeBrand init code into constructor 

    ui.Theme.from_brand() now calls ThemeBrand() directly,
but it handles reading the brand from YAML first if needed.
    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    949f6f1 View commit details
    Browse the repository at this point in the history

  7. feat(ThemeBrand): sanitize color name into valid sass/css variable names

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    2af0941 View commit details
    Browse the repository at this point in the history

  8. refactor: Use brand.color.to_dict() method 

    And rewrite the sass color var resolution for clarity
    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    03adf5c View commit details
    Browse the repository at this point in the history

  9. chore: Apply suggestions from code review

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    ced644a View commit details
    Browse the repository at this point in the history

  10. refactor: More strongly type sass var maps

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    409a53b View commit details
    Browse the repository at this point in the history

  11. refactor: Don't version the bootstrap color list

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    dcf4e32 View commit details
    Browse the repository at this point in the history

  12. refactor: Consolidate all brand.color sass var logic

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    948ddce View commit details
    Browse the repository at this point in the history

  13. refactor: Raise ThemeBrandUnmappedFieldError following envvar 

    SHINY_BRAND_YML_RAISE_UNMAPPED="true"

For testing
    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    142409e View commit details
    Browse the repository at this point in the history

  14. chore: Update brand.ya?ml reload includes

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    048622e View commit details
    Browse the repository at this point in the history

  15. Merged origin/main into feat/brand-yml

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    96a9b95 View commit details
    Browse the repository at this point in the history

  16. feat: Convert typography.base.size to rem for Bootstrap 

    Otherwise Bootstrap does calculations with incompatible units
    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    fc66b21 View commit details
    Browse the repository at this point in the history

  17. feat(brand): Add example app and brand

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    20b1210 View commit details
    Browse the repository at this point in the history

  18. feat(brand): finish mapping the variables

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b905415 View commit details
    Browse the repository at this point in the history

  19. chore: Add some notes in example brand

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    95ffd5a View commit details
    Browse the repository at this point in the history

  20. chore: add a few more notes

    @gadenbuie
    gadenbuie committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    db42401 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. refactor: Simplify splitting css value and unit 

    Co-authored-by: Carson Sievert <[email protected]>
    @gadenbuie @cpsievert
    gadenbuie and cpsievert authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f785d75 View commit details
    Browse the repository at this point in the history

  2. chore: link back to bootstrap source for code rules

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    aaed92a View commit details
    Browse the repository at this point in the history

  3. fix(brand): Map typography.link.color to $link-color-dark too

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a012b8a View commit details
    Browse the repository at this point in the history

  4. feat(example): Add colors page

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a9fb968 View commit details
    Browse the repository at this point in the history

  5. fix(typing): of split_css_value_and_unit()

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5624064 View commit details
    Browse the repository at this point in the history

  6. feat(brand): Swap foreground/background in dark mode

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    67e9b7d View commit details
    Browse the repository at this point in the history

  7. feat(brand): Pick white/black from brand's foreground/background and … 

    …make gray scale
    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c772164 View commit details
    Browse the repository at this point in the history

  8. feat(brand-example): Add color swatch page

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    2573e0a View commit details
    Browse the repository at this point in the history

  9. chore: remove sass debug output

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    e05ab3d View commit details
    Browse the repository at this point in the history

  10. feat(brand): restore card borders in dark mode if brand makes dark mode

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    484c89b View commit details
    Browse the repository at this point in the history

  11. feat(brand): Mix of font sources

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    51cf4f1 View commit details
    Browse the repository at this point in the history

  12. fix(brand): Rules for code-block-line-height

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    75ab45d View commit details
    Browse the repository at this point in the history

  13. refactor: ._handle_unmapped_variable method

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    792af38 View commit details
    Browse the repository at this point in the history

  14. refactor(ThemeBrand): Separate into smaller methods

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c5f6302 View commit details
    Browse the repository at this point in the history

  15. chore(brand): rename methods and add sass comments for dividers

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0fe7fa1 View commit details
    Browse the repository at this point in the history

  16. refactor: move theme method calls into helper methods

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    b1d0ccc View commit details
    Browse the repository at this point in the history

  17. refactor: factor out get_theme_name

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a4eee03 View commit details
    Browse the repository at this point in the history

  18. refactor: Rename BrandBootstrapConfig

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ab5085e View commit details
    Browse the repository at this point in the history

  19. feat: read layers from brand.defaults.shiny.theme.*

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    75a7f97 View commit details
    Browse the repository at this point in the history

  20. chore: Add !default flag

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    438605f View commit details
    Browse the repository at this point in the history

  21. chore: early return in no-op case

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f083519 View commit details
    Browse the repository at this point in the history

  22. refactor: Static method for brand to sass variable helpers

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    dbc4759 View commit details
    Browse the repository at this point in the history

  23. fix: brand-yml inventory objects location

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    6e57945 View commit details
    Browse the repository at this point in the history

  24. feat(typography): Map inline code color to $code-color-dark

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1c2a504 View commit details
    Browse the repository at this point in the history

  25. example(brand): Keep navbar visible

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9591fb2 View commit details
    Browse the repository at this point in the history

  26. feat: check that brand_yml is installed before using

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    721b1be View commit details
    Browse the repository at this point in the history

  27. refactor(BrandBootstrapConfig): Make static methods

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c314806 View commit details
    Browse the repository at this point in the history

  28. refactor: return brand/bootstrap color sass vars separately

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    cf103d8 View commit details
    Browse the repository at this point in the history

  29. chore: set black/white to brand black white if not set

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    82b4493 View commit details
    Browse the repository at this point in the history

  30. refactor: simplify return value

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    59b93c9 View commit details
    Browse the repository at this point in the history

  31. chore(types): Fix return value

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9e8211c View commit details
    Browse the repository at this point in the history

  32. refactor: Move preset checking into ui.Theme()

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    22bd9bd View commit details
    Browse the repository at this point in the history

  33. fix: defaults from defaults.bootstrap

    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    1242c6d View commit details
    Browse the repository at this point in the history

  34. fix: rework layer adding to ensure correct order 

    Bootstrap defaults come after brand palette but before brand vars
    @gadenbuie
    gadenbuie committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9bebe72 View commit details
    Browse the repository at this point in the history

  35. chore: update type hint 

    Co-authored-by: Carson Sievert <[email protected]>
    @gadenbuie @cpsievert
    gadenbuie and cpsievert authored Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0d72daa View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. temp: switch to brand_yml from github

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    fa78936 View commit details
    Browse the repository at this point in the history

  2. refactor: brand_yml now handles validation of color.palette names

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f7f5605 View commit details
    Browse the repository at this point in the history

  3. chore: use _add_defaults_hdr() in additional place

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    16db15d View commit details
    Browse the repository at this point in the history

  4. refactor: don't use as_css_unit() just work with strings

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    af8532a View commit details
    Browse the repository at this point in the history

  5. refactor: Call cls from inside class method

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    04b3011 View commit details
    Browse the repository at this point in the history

  6. chore(reload): On yml and yaml changes

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    d030f8d View commit details
    Browse the repository at this point in the history

  7. refactor: brand_yml handles converting typography.base.size to rem

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    90b03f5 View commit details
    Browse the repository at this point in the history

  8. refactor: simplify finding spec or pkg

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5d059e2 View commit details
    Browse the repository at this point in the history

  9. chore(examples): Add requirements.txt

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    f2d35b6 View commit details
    Browse the repository at this point in the history

  10. docs: Fill out .from_brand() documentation

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    83e4a33 View commit details
    Browse the repository at this point in the history

  11. docs: small edit

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a34e936 View commit details
    Browse the repository at this point in the history

  12. chore: slim type

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9c9b0da View commit details
    Browse the repository at this point in the history

  13. refactor: BrandBootstrapConfig

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    439f557 View commit details
    Browse the repository at this point in the history

  14. chore: Add changelog item

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    805aecd View commit details
    Browse the repository at this point in the history

  15. chore: use released brand_yml

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    65ae093 View commit details
    Browse the repository at this point in the history

  16. chore: create new dict

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    bda5054 View commit details
    Browse the repository at this point in the history

  17. chore: only import brand for type checking

    @gadenbuie
    gadenbuie committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9b73147 View commit details
    Browse the repository at this point in the history

  18. Update CHANGELOG.md

    @cpsievert
    cpsievert authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    75dcf2a View commit details
    Browse the repository at this point in the history

  19. Update _theme_brand.py 

    Co-authored-by: Carson Sievert <[email protected]>
    @gadenbuie @cpsievert
    gadenbuie and cpsievert authored Oct 25, 2024
    Configuration menu
    Copy the full SHA
    51dc33b View commit details
    Browse the repository at this point in the history

  20. example: use layout_sidebar() not page_sidebar()

    @cpsievert
    cpsievert committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    339a9aa View commit details
    Browse the repository at this point in the history

  21. example: pass brand colors along to plotting code (instead of repeati… 

    …ng them)
    @cpsievert
    cpsievert committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    edbae14 View commit details
    Browse the repository at this point in the history