Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move ui.Theme.from_brand() Sass code into an .scss file #1792

Merged
merged 11 commits into from
Dec 31, 2024
Prev Previous commit
Next Next commit
chore: remove unmapped brand sass var check
This isn't used anymore, we now create brand sass vars for everything
gadenbuie committed Dec 31, 2024
commit 6eaf92653d6c7067b58076aa86a657b1335841be
2 changes: 0 additions & 2 deletions examples/brand/app.py
Original file line number Diff line number Diff line change
@@ -7,8 +7,6 @@
from shiny import App, render, ui
from shiny.ui._theme_brand import bootstrap_colors

# TODO: Move this into the test that runs this app
os.environ["SHINY_BRAND_YML_RAISE_UNMAPPED"] = "true"
theme = ui.Theme.from_brand(__file__)
# theme = ui.Theme()
theme.add_rules((Path(__file__).parent / "_colors.scss").read_text())