Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]: preserve line breaks, make settings optional #222

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

[feat]: preserve line breaks, make settings optional #222

wants to merge 10 commits into from

Conversation

andreyvolokitin
Copy link

@andreyvolokitin
Copy link
Author

This is not complete, I plan to add an edge case here, for this (so the line break is added to fix this)

@Scrum
Copy link
Member

Scrum commented Mar 29, 2018

Fix for old node please

@andreyvolokitin
Copy link
Author

I think this is because of await, which was introduced in Node 9. I suppose it is inside pre-existing tests. Could babel-polyfill solve the problem? BTW should I write tests for my features?

@andreyvolokitin
Copy link
Author

Strange how it was not a problem before... There is await in the tests code at least since 2016, but also there are passing PRs after that as well. Maybe something happened and suddenly turned it into a problem? Probably not something in this PR...

@andreyvolokitin
Copy link
Author

Hm. Clearly not an await, there are other passing tests with it. Not sure how is this possible because I didn't add any "new" syntax which would work only with "new node"...

@Scrum
Copy link
Member

Scrum commented Apr 1, 2018

well, I'll figure it out. Thank you for your contribution - this is very important for this project.

@Scrum Scrum added this to the 0.2.1 milestone Apr 1, 2018
@Scrum Scrum self-requested a review April 9, 2018 08:15
@Scrum Scrum changed the title feat: preserve line breaks, make settings optional [feat]: preserve line breaks, make settings optional Nov 21, 2018
@Scrum Scrum changed the title [feat]: preserve line breaks, make settings optional feat: preserve line breaks, make settings optional Nov 21, 2018
@Scrum Scrum changed the title feat: preserve line breaks, make settings optional [feat]: preserve line breaks, make settings optional Nov 21, 2018
@Scrum Scrum modified the milestones: 0.2.1, 0.2.2, 0.2.4, 0.2.5 Nov 21, 2018
@andreyvolokitin andreyvolokitin mentioned this pull request Oct 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrum Scrum Awaiting requested review from Scrum

Assignees
No one assigned
Labels
pr: discuss priority: low semver: minor status: blocked type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreyvolokitin @Scrum