Changes to enable importing multiple response examples. #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponse, convertToPmResponseBody, convertToPmBodyData now return a list of bodies, changed getExampleData to handle one example at a time.
pcgamer1
changed the title
|
@meenakshi-dhanani Could you look into this. Cheers |
|
@pcgamer1 -- Thanks for your hard work on this! Hoping it can make it into the codebase as we'd love this functionality! |
|
Any chance this could be merged? Thanks. |
|
Hi, has anyone some idea if this would be merged anytime soon? I have several request examples in my OAS contract and postman-openapi importer doesn't reflect them in the import. Cann we help unblocking the code of this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89.
I had to change the return type of
convertToPmResponse,convertToPmResponseBody,convertToPmBodyDatato return a list of response bodies.@VShingala @umeshp7 @abhijitkane Please do have a look. Thanks.
I have also added a test for the same.
Please omit the duplicate commit names, I had not figured out how to run the tests locally at that time.