Add extra API keys as headers or query params #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webholik
changed the title
VShingala
requested changes
Sep 4, 2023
| if (_.isObject(security) && _.isEmpty(security)) { | ||
| helper = { | ||
| authHelper = { |
There was a problem hiding this comment.
Why are we using authHelper here specifically if it will anyways get assigned helper in line no. 1300.
| if (_.get(apiKey, 'apikey.2.value') === 'header') { | ||
| headers.push(keyValuePair); | ||
| } | ||
| else { |
There was a problem hiding this comment.
let's use else if ( === query ) { condition specifically to represent this better here. As API key can be mentioned inside cookie as well.
| const securitySet = _.get(openapi, 'security', []); | ||
| let count = 0; | ||
|
|
||
| _.forEach(securitySet, (security) => { |
There was a problem hiding this comment.
This is not how you should iterate for multiple API keys.
Take a look at this article: there are combinations of AND and OR in case when multiple keys are mentioned.
https://swagger.io/docs/specification/authentication/api-keys/?sbsearch=API%20Keys
|
@webholik Let's address the comments and make the related changes. |
Supianti0115
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we encounter extra API keys in the security rule set we will add them as extra header/query params in the request.