-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parametersResolution: Handle ENUM properties #818
base: develop
Are you sure you want to change the base?
Conversation
@VShingala The PR is ready for your review. The issue originated in the resolveSchema function, which is solved in the PR. There is an unexpected side-effect in the Validation tests, which I can't figure out what would be the expected result, perhaps you can assist? ValidateV2.test.js (Line 577)
In the past this returned a random ENUM value with I find it strange the "ValidateV2" fails, since I've build it to only execute the conversion when the operation is "CONVERSION". |
@VShingala Picking this PR up again. Can you have a look at my previous question ☝️ , and what would be the expected behaviour?
|
@thim81 Although we've only updated conversion logic, validation logic/tests works hands in hands with it. i.e. tests failing are due to converted collection not getting validated after this change. In validation workflow, we suggest changes based on schema. Till now these suggestions were of actual enums but from now they'll be |
hi @VShingala So if I understand properly, I can update the validation test to check for the For me it is not really clear, how to fix the validation tests, without impacting the expected behaviour. |
Linked to #817