Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostgreSQL to CI #307

Merged
merged 9 commits into from
May 21, 2024
Merged

Add PostgreSQL to CI #307

merged 9 commits into from
May 21, 2024

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented May 9, 2024

Run the audiences gem tests on both MySQL and PostgreSQL to ensure compatibility.

@xjunior xjunior force-pushed the postgresql-workflow branch 2 times, most recently from 79984a3 to 8d1f268 Compare May 9, 2024 21:11
@xjunior xjunior changed the title Inline ruby workflow with postgresql Ruby workflow with postgresql May 9, 2024
@xjunior xjunior force-pushed the postgresql-workflow branch 20 times, most recently from becd4dd to e00da61 Compare May 10, 2024 21:22
@xjunior xjunior changed the title Ruby workflow with postgresql Add support to PostgreSQL May 10, 2024
@xjunior xjunior force-pushed the postgresql-workflow branch 2 times, most recently from e00da61 to d532643 Compare May 13, 2024 18:46
xjunior added a commit that referenced this pull request May 14, 2024
Fixes known issues on PostgreSQL. These fixes have been validated on
#307. The build including
PostgreSQL is bein prepared on that PR, but have been cherry-picked here
to unblock users of Audiences.

- **Use unique_by when needed**
- **Aggregate failures**
- **Assert on ordered data**
- **Allow user search on multiple adapters**
@xjunior xjunior force-pushed the postgresql-workflow branch from d532643 to 15ed189 Compare May 14, 2024 14:26
@xjunior xjunior force-pushed the postgresql-workflow branch from f0aaad6 to b2bf3e2 Compare May 20, 2024 21:00
@xjunior xjunior marked this pull request as ready for review May 20, 2024 21:27
@xjunior xjunior requested a review from a team as a code owner May 20, 2024 21:27
@xjunior xjunior enabled auto-merge (squash) May 21, 2024 17:39
@xjunior xjunior changed the title Add support to PostgreSQL Add PostgreSQL to CI May 21, 2024
@xjunior xjunior disabled auto-merge May 21, 2024 17:48
phylum
phylum previously approved these changes May 21, 2024
web-kat
web-kat previously approved these changes May 21, 2024
phylum
phylum previously approved these changes May 21, 2024
@xjunior xjunior dismissed stale reviews from phylum and web-kat via 6f3c476 May 21, 2024 18:11
@xjunior xjunior enabled auto-merge (squash) May 21, 2024 18:13
@xjunior xjunior merged commit 977d2fc into main May 21, 2024
16 checks passed
@xjunior xjunior deleted the postgresql-workflow branch May 21, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants