Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Tweaks from UX handoffs #329

Merged
merged 17 commits into from
Jun 4, 2024
Merged

UI Tweaks from UX handoffs #329

merged 17 commits into from
Jun 4, 2024

Conversation

xjunior
Copy link
Contributor

@xjunior xjunior commented Jun 4, 2024 •
edited
Loading

Screen.Recording.2024-06-04.at.13.01.49.mov
  • Standardize on Members for a more generic lingo
  • Extract toSentence
  • Change Add criteria button label
  • Use suggested visual components for CriteriaDescription
  • Use regular sized caption for members total
  • Hide criterion card before it has anything
  • Inline Members component and tweak UI spacings
  • Tweak margins
  • Add individuals before group criteria
  • Disable form while submitting
  • Fix DATABASE_HOST env var name
  • Hide separator when all is toggled on
  • Refactor criteria form
  • Change action labels
  • Make back button functional

@xjunior xjunior requested a review from a team June 4, 2024 14:44
@xjunior xjunior requested a review from a team as a code owner June 4, 2024 14:44
@xjunior xjunior merged commit 0421ce2 into main Jun 4, 2024
16 checks passed
@xjunior xjunior deleted the ui-tweaks branch June 4, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@web-kat web-kat web-kat approved these changes

@phylum phylum phylum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xjunior @phylum @web-kat