Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alloc overhead in hot path for keyboard checks #6368

Merged
merged 1 commit into from
Sep 4, 2024

Fix alloc overhead in hot path for keyboard checks

fa9bd17
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix alloc overhead in hot path for keyboard checks #6368

Fix alloc overhead in hot path for keyboard checks
fa9bd17
Select commit
Loading
Failed to load commit list.
GitHub Actions / Test Results (macOS, MultiThreaded, Debug) failed Sep 4, 2024 in 0s

3146 passed, 1 failed and 79 skipped

Tests failed

❌ TestResults-macOS-MultiThreaded-Debug.trx

3226 tests were completed in 731s with 3146 passed, 1 failed and 79 skipped.

Test suite Passed Failed Skipped Time
osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper 4✅ 1❌ 4s

❌ osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper

✅ TestConstructor
✅ TestManyChildren(False)
✅ TestManyChildren(True)
✅ TestManyChildrenFunction(False)
❌ TestManyChildrenFunction(True)
	not too many loaded

Annotations

Check failure on line 0 in TestResults-macOS-MultiThreaded-Debug.trx

See this annotation in the file changed.

@github-actions github-actions / Test Results (macOS, MultiThreaded, Debug)

osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper ► TestManyChildrenFunction(True) 

Failed test found in:
  TestResults-macOS-MultiThreaded-Debug.trx
Error:
  not too many loaded
Raw output 
not too many loaded
   at osu.Framework.Threading.ScheduledDelegate.InvokeTask()
   at osu.Framework.Threading.ScheduledDelegate.RunTaskInternal()
   at osu.Framework.Threading.Scheduler.Update()
   at osu.Framework.Graphics.Drawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.updateChild(Drawable c)
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.updateChild(Drawable c)
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.updateChild(Drawable c)
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.updateChild(Drawable c)
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.updateChild(Drawable c)
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.updateChild(Drawable c)
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Graphics.Containers.CompositeDrawable.updateChild(Drawable c)
   at osu.Framework.Graphics.Containers.CompositeDrawable.UpdateSubTree()
   at osu.Framework.Platform.GameHost.UpdateFrame()
   at osu.Framework.Platform.HeadlessGameHost.UpdateFrame()
   at osu.Framework.Threading.GameThread.processFrame()
   at osu.Framework.Threading.GameThread.RunSingleFrame()
   at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
   at System.Threading.Thread.StartHelper.Callback(Object state)
View more details on GitHub Actions