Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback iOS workload to last known working version #6384

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

smoogipoo
Copy link
Contributor

This is required to get osu! running on iOS again.

Out of...

  • .NET SDK versions 8.0.302 (last known working) and 8.0.400 (latest).
  • Xcode versions 15.4 (last known working) and 16.0 (latest).
  • iOS SDK/manifest versions 17.2.8053 (last known working) and 18.0.8303 (latest)

... I've isolated the problematic component to be the iOS SDK.

The version 17.2.8053 is a well-informed estimate based on release dates respective to the last working iOS release (2024.625.2) and can be cross-referenced with the manifest's nuget package: https://www.nuget.org/packages/Microsoft.NET.Sdk.iOS.Manifest-8.0.100/17.2.8053

  • My assumption is that the following manifest version 17.2.8078 does not work. This is the only version that was pushed in-between two of our releases, the last-known working one and the first-known broken one. I am also not having a fun experience compiling with this SDK - it's likely the version where Microsoft broke AOT deduplication and many other things along with it.
  • While the rolled-back SDK works with Xcode 16, it also works with 15.4, and I've also had better experience compiling with 15.4 (compile-time-wise). So I've reverted it. It's good to note, though, as Xcode 16 will be the only available option when GHA eventually upgrades to macOS-15.
  • .NET SDK 8.0.400 added workload sets that would simplify this by allowing us to store it in global.json. Unfortunately the earliest available workload set uses the 17.2.8078 manifest, which is the first version that does not work for us.
  • We will still need to isolate the issue further and report to Microsoft. I provided some initial commentary here. It might be worthwhile to check this prior to .NET 9's release (and also check if it's fixed with .NET 9).

I have tested an iOS build with full auth + score submission.

@peppy peppy merged commit 3091897 into ppy:master Oct 5, 2024
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants