Merge pull request #29966 from bdach/unsafe-deep-clone

Fix score being cloned in async method causing random errors (again)
ppy · Sep 23, 2024 · f08134f · f08134f
2 parents 31e4230 + 881c9df
commit f08134f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/osu.Game/Screens/Play/SubmittingPlayer.cs b/osu.Game/Screens/Play/SubmittingPlayer.cs
@@ -234,9 +234,12 @@ private void submitFromFailOrQuit()
         {
             if (LoadedBeatmapSuccessfully)
             {
+                // compare: https://github.com/ppy/osu/blob/ccf1acce56798497edfaf92d3ece933469edcf0a/osu.Game/Screens/Play/Player.cs#L848-L851
+                var scoreCopy = Score.DeepClone();
+
                 Task.Run(async () =>
                 {
-                    await submitScore(Score.DeepClone()).ConfigureAwait(false);
+                    await submitScore(scoreCopy).ConfigureAwait(false);
                     spectatorClient.EndPlaying(GameplayState);
                 }).FireAndForget();
             }