Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keybind for cycling grid type #26303

Merged
merged 14 commits into from
Oct 16, 2024
Merged

Add keybind for cycling grid type #26303

merged 14 commits into from
Oct 16, 2024
+119 −14

Commits on Oct 11, 2024

  1. use G to change grid type

    @OliBomby
    OliBomby committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d98cc7f View commit details
    Browse the repository at this point in the history

  2. fix grid test

    @OliBomby
    OliBomby committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    bfe78ff View commit details
    Browse the repository at this point in the history

  3. Add TestGridFromPoints

    @OliBomby
    OliBomby committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e56a9d2 View commit details
    Browse the repository at this point in the history

  4. Add back the old keybind for cycling grid spacing

    @OliBomby
    OliBomby committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b93bc21 View commit details
    Browse the repository at this point in the history

  5. Fix grid type cycling not taking into account the radio button selection

    @OliBomby
    OliBomby committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ada20d2 View commit details
    Browse the repository at this point in the history

  6. Update grid placement tool test 

    I somehow missed this test when splitting up PRs so here it is now
    @OliBomby
    OliBomby committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    56bfcde View commit details
    Browse the repository at this point in the history

  7. Rename "Cycle grid display mode" to "Cycle grid spacing" 

    The "display mode" is easy to confuse with grid type, so I renamed it to literally the grid property it affects.
    @OliBomby
    OliBomby committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    550e575 View commit details
    Browse the repository at this point in the history

  8. Change shortcut to Shift+G

    @peppy
    peppy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d07a2fb View commit details
    Browse the repository at this point in the history

  9. Simplify cycle logic

    @peppy
    peppy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    05c8b3c View commit details
    Browse the repository at this point in the history

  10. Fix bindings being clobbered

    @peppy
    peppy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b62d9f8 View commit details
    Browse the repository at this point in the history

  11. Update test

    @peppy
    peppy committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    8b046f6 View commit details
    Browse the repository at this point in the history

  12. Explicitly assert specific grid type

    @OliBomby
    OliBomby committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    9f73a45 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'master' into grids

    @bdach
    bdach committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    dcf78a6 View commit details
    Browse the repository at this point in the history

  2. Remove unused field 

    Not sure why inspectcode is quiet about this?
    @bdach
    bdach committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    882df6b View commit details
    Browse the repository at this point in the history