Add colour customisation to layout editor #29936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Sep 20, 2024
| // Copyright (c) ppy Pty Ltd <[email protected]>. Licensed under the MIT Licence. | ||
| // See the LICENCE file in the repository root for full licence text. | ||
|
|
||
| #nullable disable |
There was a problem hiding this comment.
#nullable disable is not allowed in any new code
| @@ -29,6 +30,9 @@ public partial class ArgonSongProgress : SongProgress | |||
| [SettingSource(typeof(SongProgressStrings), nameof(SongProgressStrings.ShowTime), nameof(SongProgressStrings.ShowTimeDescription))] | |||
| public Bindable<bool> ShowTime { get; } = new BindableBool(true); | |||
|
|
|||
| [SettingSource(typeof(SkinnableComponentStrings), nameof(SkinnableComponentStrings.Colour), nameof(SkinnableComponentStrings.ColourDescription))] | |||
| public new BindableColour4 Colour { get; } = new BindableColour4(Colour4.White); | |||
There was a problem hiding this comment.
Not a fan of the shadowing here (the usage of new) or the usage of base underneath. I'd rename all of these to AccentColour which gets rid of both.
| @@ -20,11 +21,16 @@ public abstract partial class FontAdjustableSkinComponent : Container, ISerialis | |||
| [SettingSource(typeof(SkinnableComponentStrings), nameof(SkinnableComponentStrings.Font), nameof(SkinnableComponentStrings.FontDescription))] | |||
| public Bindable<Typeface> Font { get; } = new Bindable<Typeface>(Typeface.Torus); | |||
|
|
|||
| [SettingSource(typeof(SkinnableComponentStrings), nameof(SkinnableComponentStrings.FontColour), nameof(SkinnableComponentStrings.FontColourDescription))] | |||
| public BindableColour4 FontColour { get; } = new BindableColour4(Colour4.White); | |||
There was a problem hiding this comment.
Please rename this (and all associated members) to TextColour. Fonts don't have colours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to change colour for:
AdjustingColour.mp4
I also implemented this to
FontAdjustableSkinComponentbecause it makes sense but I'm not too sure.I don't think there's design for button for adjusting colour, so I came up with my own.