Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colour customisation to layout editor #29936

Merged
merged 14 commits into from
Sep 27, 2024

Conversation

u4vh3
Copy link
Contributor

@u4vh3 u4vh3 commented Sep 19, 2024

Allows you to change colour for:

  • Argon wedge piece
  • Box element
  • Default and argon song progress
  • Font adjustable components
AdjustingColour.mp4

I also implemented this to FontAdjustableSkinComponent because it makes sense but I'm not too sure.

I don't think there's design for button for adjusting colour, so I came up with my own.

@bdach bdach self-requested a review September 20, 2024 08:11
osu.Game/Screens/Play/HUD/ArgonSongProgress.cs Outdated Show resolved Hide resolved
osu.Game/Skinning/FontAdjustableSkinComponent.cs Outdated Show resolved Hide resolved
bdach
bdach previously approved these changes Sep 24, 2024
Copy link
Collaborator

@bdach bdach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure I guess?

@bdach bdach requested a review from peppy September 24, 2024 11:03
Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty okay otherwise.

osu.Game/Screens/Play/HUD/ArgonSongProgress.cs Outdated Show resolved Hide resolved
osu.Game/Screens/Play/HUD/DefaultSongProgress.cs Outdated Show resolved Hide resolved
@peppy peppy merged commit 5efdc6c into ppy:master Sep 27, 2024
11 of 13 checks passed
@u4vh3 u4vh3 deleted the skinning-colour-customisation branch September 27, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants