-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vital-vs for fixing to scroll bordererd-window #1556
Conversation
@@ -67,6 +115,8 @@ else | |||
function! l:ctx.callback() abort | |||
let self.info.width = winwidth(0) | |||
let self.info.height = winheight(0) | |||
let self.info.core_width = self.info.width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[vint] reported by reviewdog 🐶
Make the scope explicit like l:self
(see Anti-pattern of vimrc (Scope of identifier))
@@ -67,6 +115,8 @@ else | |||
function! l:ctx.callback() abort | |||
let self.info.width = winwidth(0) | |||
let self.info.height = winheight(0) | |||
let self.info.core_width = self.info.width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[vint] reported by reviewdog 🐶
Make the scope explicit like l:self
(see Anti-pattern of vimrc (Scope of identifier))
@@ -67,6 +115,8 @@ else | |||
function! l:ctx.callback() abort | |||
let self.info.width = winwidth(0) | |||
let self.info.height = winheight(0) | |||
let self.info.core_width = self.info.width | |||
let self.info.core_height = self.info.height |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[vint] reported by reviewdog 🐶
Make the scope explicit like l:self
(see Anti-pattern of vimrc (Scope of identifier))
@@ -67,6 +115,8 @@ else | |||
function! l:ctx.callback() abort | |||
let self.info.width = winwidth(0) | |||
let self.info.height = winheight(0) | |||
let self.info.core_width = self.info.width | |||
let self.info.core_height = self.info.height |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[vint] reported by reviewdog 🐶
Make the scope explicit like l:self
(see Anti-pattern of vimrc (Scope of identifier))
@@ -67,6 +115,8 @@ else | |||
function! l:ctx.callback() abort | |||
let self.info.width = winwidth(0) | |||
let self.info.height = winheight(0) | |||
let self.info.core_width = self.info.width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[vint] reported by reviewdog 🐶
Make the scope explicit like l:self
(see Anti-pattern of vimrc (Scope of identifier))
@@ -67,6 +115,8 @@ | |||
function! l:ctx.callback() abort | |||
let self.info.width = winwidth(0) | |||
let self.info.height = winheight(0) | |||
let self.info.core_width = self.info.width |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[vint] reported by reviewdog 🐶
Make the scope explicit like l:self
(see Anti-pattern of vimrc (Scope of identifier))
@@ -67,6 +115,8 @@ | |||
function! l:ctx.callback() abort | |||
let self.info.width = winwidth(0) | |||
let self.info.height = winheight(0) | |||
let self.info.core_width = self.info.width | |||
let self.info.core_height = self.info.height |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[vint] reported by reviewdog 🐶
Make the scope explicit like l:self
(see Anti-pattern of vimrc (Scope of identifier))
@@ -67,6 +115,8 @@ | |||
function! l:ctx.callback() abort | |||
let self.info.width = winwidth(0) | |||
let self.info.height = winheight(0) | |||
let self.info.core_width = self.info.width | |||
let self.info.core_height = self.info.height |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[vint] reported by reviewdog 🐶
Make the scope explicit like l:self
(see Anti-pattern of vimrc (Scope of identifier))
Merged. Thanks! |
fix this discussion #1555 .