Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vital-vs for fixing to scroll bordererd-window #1556

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

hrsh7th
Copy link
Collaborator

@hrsh7th hrsh7th commented May 10, 2024

fix this discussion #1555 .

@@ -67,6 +115,8 @@ else
function! l:ctx.callback() abort
let self.info.width = winwidth(0)
let self.info.height = winheight(0)
let self.info.core_width = self.info.width

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))

@@ -67,6 +115,8 @@ else
function! l:ctx.callback() abort
let self.info.width = winwidth(0)
let self.info.height = winheight(0)
let self.info.core_width = self.info.width

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))

@@ -67,6 +115,8 @@ else
function! l:ctx.callback() abort
let self.info.width = winwidth(0)
let self.info.height = winheight(0)
let self.info.core_width = self.info.width
let self.info.core_height = self.info.height

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))

@@ -67,6 +115,8 @@ else
function! l:ctx.callback() abort
let self.info.width = winwidth(0)
let self.info.height = winheight(0)
let self.info.core_width = self.info.width
let self.info.core_height = self.info.height

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))

@@ -67,6 +115,8 @@ else
function! l:ctx.callback() abort
let self.info.width = winwidth(0)
let self.info.height = winheight(0)
let self.info.core_width = self.info.width
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))

@@ -67,6 +115,8 @@
function! l:ctx.callback() abort
let self.info.width = winwidth(0)
let self.info.height = winheight(0)
let self.info.core_width = self.info.width
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))

@@ -67,6 +115,8 @@
function! l:ctx.callback() abort
let self.info.width = winwidth(0)
let self.info.height = winheight(0)
let self.info.core_width = self.info.width
let self.info.core_height = self.info.height
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))

@@ -67,6 +115,8 @@
function! l:ctx.callback() abort
let self.info.width = winwidth(0)
let self.info.height = winheight(0)
let self.info.core_width = self.info.width
let self.info.core_height = self.info.height
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[vint] reported by reviewdog 🐶
Make the scope explicit like l:self (see Anti-pattern of vimrc (Scope of identifier))

@prabirshrestha prabirshrestha merged commit 356254d into master Aug 5, 2024
18 checks passed
@prabirshrestha
Copy link
Owner

Merged. Thanks!

@prabirshrestha prabirshrestha deleted the scroll-border branch August 5, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants