Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing borders to Neovim's floating windows #1565

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Jorenar
Copy link
Contributor

@Jorenar Jorenar commented Jul 9, 2024

Related to issue #1207

In Vim, when e.g. peeking at type definition, the popup windows have a border drawn around them:
screenshot-20240709_222924

While in Neovim such border is missing:
screenshot-20240709_223010

With the small fix from this PR:
screenshot-20240709_223146

The readability is quite improved.

@prabirshrestha
Copy link
Owner

prabirshrestha commented Jul 20, 2024

I already seem to be having border in Neovim.

image

@Jorenar
Copy link
Contributor Author

Jorenar commented Jul 20, 2024

@prabirshrestha
Oh right, I forgot to mention that :LspHover do have a border and it is indeed the same single line in both Vim and Neovim.
The other popup windows (like e.g. for :LspTypeDefinition) have double line border in Vim, and no border in Neovim.

@Jorenar
Copy link
Contributor Author

Jorenar commented Aug 3, 2024

@prabirshrestha ?

@prabirshrestha prabirshrestha merged commit 396d248 into prabirshrestha:master Aug 5, 2024
18 checks passed
@prabirshrestha
Copy link
Owner

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants