Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx-basic-ng to a real version #853

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Blendify
Copy link

@Blendify Blendify commented Nov 28, 2024

The version number here does not correspond to a proper release on pypi and can cause some problems for some installations.

This was mistakenly changed in 2ce7e89

The version number here does not correspond to a proper release on pypi and can cause some problems for some installations.
hubot pushed a commit to blender/blender that referenced this pull request Nov 28, 2024
The upstream dependency was mistakenly changed in
pradyunsg/furo@2ce7e89

PR to fix this here: pradyunsg/furo#853
@pradyunsg
Copy link
Owner

pradyunsg commented Jan 1, 2025

Thanks for filing this PR!

This difference should not matter for Python packages, since both of these forms normalize to the same value under the hood:

>>> from packaging.version import Version as V
>>> V("1.0.0b2")
<Version('1.0.0b2')>
>>> V("1.0.0.beta2")
<Version('1.0.0b2')>

@ferdnyc
Copy link
Contributor

ferdnyc commented Jan 1, 2025

This difference should not matter for Python packages, since both of these forms normalize to the same value under the hood

And just to reinforce that a bit more, even a pip install will normalize the version and do the right thing:

$ pip --no-cache install sphinx-basic-ng==1.0.0.beta2
Collecting sphinx-basic-ng==1.0.0.beta2
  Downloading sphinx_basic_ng-1.0.0b2-py3-none-any.whl.metadata (1.5 kB)
[...]
Downloading sphinx_basic_ng-1.0.0b2-py3-none-any.whl (22 kB)
[...installs...]

So if an installation is having problems locating a package, they should normalize their versions first.

@Blendify
Copy link
Author

Blendify commented Jan 3, 2025

Interesting, we had issues with Pipenv and 2ce7e89

Prior to that release we didnt have to use --pre to install furo. Ideally it would be nice if we can get a real version of that dependency released.

@pradyunsg
Copy link
Owner

That sounds like a pipenv bug rather than a metadata issue in this package.

Prior to that release we didnt have to use --pre to install furo

That should also not be necessary. Pre-releases are supposed to be opted-in for that package, via the fact that the constraint allows for a pre-release.

None the less, I do plan to cut a non-pre-release version for that eventually -- there's a bunch of work on that end that I need to do.

pradyunsg/sphinx-theme-builder#11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants