Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Home Page for Website #17

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

codervivek5
Copy link

@codervivek5 codervivek5 commented Feb 1, 2022

I have created a home page for the website. I have added an image folder for the image and add a CSS folder for the styling purpose.

Related Issue

  • Info about the related issue

  • JWOC Participant

  • Contributor

Closes: #2

Describe the changes you've made

Give a clear description what modifications you have made

Type of change

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Describe how have you verified the changes made

Checklist:

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
Original Screenshot Updated Screenshot
image image

I have created a home page for the website. I have added an image folder for the image and add a CSS folder for the styling purpose.
@prathimacode-hub
Copy link
Owner

Enable the checklist, add the output screenshot and issue number you got allotted to in format given. Use edit option to correct the PR message. @codervivek5

@unnikrishnan2002
Copy link
Collaborator

@codervivek5 Pull all the changes and commit once more to resolve merge conflicts

@prathimacode-hub
Copy link
Owner

@codervivek5, drop me a message. There are few things to discuss with respect to your PR.

@unnikrishnan2002, thanks for your timely suggestion to your mate

@codervivek5
Copy link
Author

I have made all the changes, Enable the checklist, add the output screenshot and issue number.

@unnikrishnan2002
Copy link
Collaborator

@codervivek5 Pull all the changes and commit once more to resolve merge conflicts

@codervivek5

@codervivek5
Copy link
Author

@unnikrishnan2002 how will I do it? I don't know about it.

@prathimacode-hub
Copy link
Owner

There is a correction to clear out few things in PR. Kindly drop a message in discord @codervivek5

@prathimacode-hub
Copy link
Owner

I provided the video to resolve merge conflicts. It's in pinned messages you can check it. And there are corrections in your PR. So reach out to me once @codervivek5

adjust size and position of the search box
@prathimacode-hub
Copy link
Owner

Come on discussion @codervivek5

@Swatilekha-Roy
Copy link
Contributor

@codervivek5 your pr has merge conflicts- would you mind resolving them?

@codervivek5
Copy link
Author

This is so confusing to use. I have done my work but it is on my local PC. how can I add more new changes to my code so that you can see how it is looking and what we have to change on there.

index.html Outdated
@@ -17,6 +17,10 @@
<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.15.4/css/all.css"
integrity="sha384-DyZ88mC6Up2uqS4h/KRgHuoeGwBcD4Ng9SiP4dIRy0EXTlnuz47vAwmeGwVChigm" crossorigin="anonymous">

<!-- custome css for home page -->
<link rel="stylesheet" href="css/home_style.css">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codervivek5 you have to use styles.css to style the elements in index.html . Don't need to create a new css file . Put the css in styles. css file only

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unnikrishnan2002 for being so helpful in supporting your fellow mentee. Appreciate your willingness to do so.

Are you able to do so @codervivek5

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i will do that...

 We have updated some changes in the home page design.
this is extra file so we have  to delete this file
 We have to merge the deleted CSS file code of the home page to style.css file
 we have added some images for the design of the home page.
@prathimacode-hub
Copy link
Owner

Reach out to me once on discord @codervivek5

@prathimacode-hub
Copy link
Owner

Update please? @codervivek5

@codervivek5
Copy link
Author

@prathimacode-hub why it is showing merge conflict again and again.

@prathimacode-hub
Copy link
Owner

because new PR's are merging then conflict raises up. Since code gets changes and ur forked repo drastically won't be even with main repo after Latest PR's are merged @codervivek5

@codervivek5
Copy link
Author

because new PR's are merging then conflict raises up. Since code gets changes and ur forked repo drastically won't be even with main repo after Latest PR's are merged @codervivek5

I have done merge conflict........sorry I was busy for some time due to the sister's marriage now I am free for contribution.

@codervivek5
Copy link
Author

plz, check out PR.
and also plz tell me any problem or adding or designing in the home page. i will solve here.

@prathimacode-hub
Copy link
Owner

Can you update about this? @codervivek5

@codervivek5
Copy link
Author

Can you update about this? @codervivek5

Sure ....but what we have to update....

@prathimacode-hub
Copy link
Owner

Reach out to me once and there are merge conflicts too. @codervivek5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treksy : Improvise Home Page for Website
4 participants