Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-668] Manage all the source and sink configurations in Flink ConfigOptions #670

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

thekingofcity
Copy link
Contributor

Signed-off-by: thekingofcity [email protected]

Change log description
It could be better if we have a central place to store all the client configurations, but now we are separating them in each of the source/sink builder.
This is not an ideal way because these configurations are not clearly exposed to the end users.

Purpose of the change
Fix #668

What the code does
Use a new PravegaOptions to set and get Pravega client config.

How to verify it
.\gradlew clean build should pass.

@codecov
Copy link

codecov bot commented Apr 1, 2022

Codecov Report

Merging #670 (be45af3) into master (336172a) will decrease coverage by 0.70%.
The diff coverage is 73.12%.

@@             Coverage Diff              @@
##             master     #670      +/-   ##
============================================
- Coverage     82.62%   81.92%   -0.71%     
- Complexity      574      588      +14     
============================================
  Files            60       62       +2     
  Lines          2677     2877     +200     
  Branches        226      238      +12     
============================================
+ Hits           2212     2357     +145     
- Misses          291      339      +48     
- Partials        174      181       +7     
Impacted Files Coverage Δ
...nectors/flink/config/PravegaClientConfigUtils.java 35.48% <35.48%> (ø)
.../connectors/flink/source/PravegaSourceBuilder.java 60.00% <57.73%> (-5.22%) ⬇️
...a/connectors/flink/config/PravegaClientConfig.java 100.00% <100.00%> (ø)
...pravega/connectors/flink/source/PravegaSource.java 100.00% <100.00%> (ø)
.../connectors/flink/source/PravegaSourceOptions.java 90.90% <100.00%> (+28.40%) ⬆️
...link/source/enumerator/PravegaSplitEnumerator.java 87.69% <100.00%> (+0.19%) ⬆️
...ectors/flink/source/reader/PravegaSplitReader.java 85.36% <100.00%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 336172a...be45af3. Read the comment docs.

Signed-off-by: thekingofcity <[email protected]>
Signed-off-by: thekingofcity <[email protected]>
Signed-off-by: thekingofcity <[email protected]>
Signed-off-by: thekingofcity <[email protected]>
Signed-off-by: thekingofcity <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage all the source and sink configurations in Flink ConfigOptions
2 participants