-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 256: Enable stream tag API on the RUST client. #270
Conversation
Signed-off-by: Sandeep <[email protected]>
Signed-off-by: Sandeep <[email protected]>
Signed-off-by: Sandeep <[email protected]>
Signed-off-by: Sandeep <[email protected]>
Signed-off-by: Sandeep <[email protected]>
Signed-off-by: Sandeep <[email protected]>
Signed-off-by: Sandeep <[email protected]>
Signed-off-by: Sandeep <[email protected]>
Signed-off-by: Sandeep <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #270 +/- ##
==========================================
+ Coverage 73.83% 76.58% +2.74%
==========================================
Files 44 44
Lines 10450 11066 +616
==========================================
+ Hits 7716 8475 +759
+ Misses 2734 2591 -143
|
@tkaitchuck @Tristan1900 The Pravega PR for Stream tags has been merged. Could you review this changeset ? |
controller-client/src/paginator.rs
Outdated
/// | ||
/// The below snippets show case the example uses. | ||
/// Sample 1: | ||
///```ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be no_run
. Or maybe this trick because we still want to know if it doesn't compile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I have improved the snippet to enable compilation check.
Signed-off-by: Sandeep <[email protected]>
Signed-off-by: Sandeep <[email protected]>
Change log description
Purpose of the change
Fixes #256
What the code does
The following APIs have been enabled.
How to verify it
All the existing and newly added tests should pass.
Integration tests have been created to run against the latest version of Pravega.