-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 153: Add Rollback support for Pravega Cluster #255
Conversation
Signed-off-by: pbelgundi <[email protected]>
Signed-off-by: pbelgundi <[email protected]>
Signed-off-by: pbelgundi <[email protected]>
…into issue-153-auto-rollback
Signed-off-by: pbelgundi <[email protected]>
Thanks for modifying the flow to cater mostly to manual upgrade, Prajakta! Some of these tweaks are also really helpful, like the enhanced statuses. I have gone through the diff and this approach seems good to me. That being said, I would like someone else to approve in my stead, mainly due to my lack of deep understanding of the Pravega codebase and practices. |
@bourgeoisor, thanks for your comments. |
Signed-off-by: pbelgundi <[email protected]>
…into issue-153-auto-rollback
Signed-off-by: pbelgundi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have time to look at the details, but the main issue that I mentioned earlier has been resolved (thank you!).
Signed-off-by: pbelgundi <[email protected]>
Signed-off-by: pbelgundi <[email protected]>
Signed-off-by: pbelgundi <[email protected]>
Signed-off-by: pbelgundi <[email protected]>
Signed-off-by: pbelgundi <[email protected]>
Signed-off-by: pbelgundi <[email protected]>
…into issue-153-auto-rollback
Signed-off-by: pbelgundi <[email protected]>
Signed-off-by: pbelgundi <[email protected]>
…into issue-153-auto-rollback
Signed-off-by: pbelgundi [email protected]
Change log description
Purpose of the change
Fixes #153
How to verify it
RollbackInProgress
set to Status=true.This is indicated by all pravega replicas moving back to the older version and re-starting successfully.
Tested rollback after a failing upgrade in each component - bookkeeper, controller and segmentstore and in all 3 cases the cluster was successfully restored back to the previous version.
Error
with Status=true and Reason =RollbackFailed
and manual intervention would be needed to recover from this state.