File locked during deletion - fix #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin-j-joshi
requested changes
Sep 27, 2023
| state.deleteCompletedFile(file.fileName); | ||
| } | ||
| else{ | ||
| log.info("Unable to obtain lock"); |
There was a problem hiding this comment.
Add file name to message.
Also, should this be WARN?
| log.warn("Unable to delete ingested file {}", e); | ||
| // We can continue on this error. It will be retried on the next iteration. | ||
| log.warn("Unable to delete ingested file {}", e.getMessage()); | ||
| log.warn("File is locked by another process. Will retry deletion."); |
There was a problem hiding this comment.
This log line will be written for any exception not just when file is locked.
This is not correct we should have this message only when it is really locked by other process.
There was a problem hiding this comment.
I've modified it.
| log.warn("Unable to delete ingested file {}", e); | ||
| // We can continue on this error. It will be retried on the next iteration. | ||
| log.warn("Unable to delete ingested file {}", e.getMessage()); | ||
| log.warn("File is locked by another process. Will retry deletion."); |
There was a problem hiding this comment.
I've modified it.
sachin-j-joshi
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update will obtain a lock on the file before triggering deletion. If the lock is not acquired, file deletion will be skipped and retried.
Testing:
Tested using a python script to lock the file. The file was ingested and deleted after the lock was released.