Support ingestion from multiple directories #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachin-j-joshi
requested changes
Oct 12, 2023
...sensor-collector/src/main/java/io/pravega/sensor/collector/parquet/ParquetFileProcessor.java
Outdated
Show resolved
Hide resolved
sachin-j-joshi
approved these changes
Oct 23, 2023
pravega-sensor-collector/src/test/resources/RawFileIngest.properties
Outdated
Show resolved
Hide resolved
sachin-j-joshi
merged commit d7aa4b7
into
pravega:stability-improvements
1 check passed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for user to ingest files from multiple folders.
The directory paths can be separated by commas and passed to FILE_SPEC parameter. The directory paths will be iterated over, and each directory will be recursively scanned (in case of subdirectories) for files with the provided FILE_EXTENSION to obtain a list of files. The list of files will then be ingested.
Code for getting list of files from directories has been moved to io.pravega.sensor.collector.util.FileUtils.java
FileNameWithOffset.java and PravegaWriterEvent.java have also been refactored into io.pravega.sensor.collector.util package.