File Ingestion and Processing refactor #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shwetha N <[email protected]>
Signed-off-by: Shwetha N <[email protected]>
Signed-off-by: Shwetha N <[email protected]>
There was a problem hiding this comment.
LGTM.
There are some minor comments.
- Please add comments to all public classes/interfaces/methods
- Wherever possible Pass interface arguments instead of concrete classes
- Remove commented out code if not relevant/needed anymore
This is a significant change. Let's test it end to end thoroughly.
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/file/EventGenerator.java
Outdated
Show resolved
Hide resolved
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/file/FileProcessor.java
Outdated
Show resolved
Hide resolved
...ga-sensor-collector/src/main/java/io/pravega/sensor/collector/file/FileProcessorFactory.java
Show resolved
Hide resolved
...ga-sensor-collector/src/main/java/io/pravega/sensor/collector/file/FileProcessorFactory.java
Outdated
Show resolved
Hide resolved
| config = new FileConfig("tset.db","/opt/pravega-sensor-collector/Files/A","parquet","key12", | ||
| "stream1","{}",10, false, | ||
| true,20.0,"RawFileIngestService"); | ||
| /*writer = EventWriter.create( |
There was a problem hiding this comment.
please remove commented code
apoorva918
reviewed
Nov 15, 2023
...llector/src/main/java/io/pravega/sensor/collector/file/csvfile/CsvFileSequenceProcessor.java
Outdated
Show resolved
Hide resolved
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/file/FileProcessor.java
Show resolved
Hide resolved
apoorva918
reviewed
Nov 16, 2023
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/file/FileConfig.java
Show resolved
Hide resolved
Signed-off-by: Shwetha N <[email protected]>
Signed-off-by: Shwetha N <[email protected]>
Signed-off-by: Shwetha N <[email protected]>
sachin-j-joshi
merged commit 3ccd4ef
into
pravega:stability-improvements
1 check passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
At present logic for read files and ingest events to Pravega looks similar across below file types.
- CSV - log files
- parquet files
- raw files
What code does: