Issue 46: Watchdog service for Pravega Sensor Collector #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhin Balur <[email protected]>
Signed-off-by: Abhin Balur <[email protected]>
Signed-off-by: Abhin Balur <[email protected]>
abhinb
requested review from
dada-dell-emc and
sachin-j-joshi
and removed request for
dada-dell-emc
Signed-off-by: Abhin Balur <[email protected]>
Signed-off-by: Abhin Balur <[email protected]>
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/metrics/Metric.java
Show resolved
Hide resolved
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/metrics/Metric.java
Show resolved
Hide resolved
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/metrics/Metric.java
Show resolved
Hide resolved
| } | ||
|
|
||
|
|
||
| class ExceptionMeter implements Metric<String> { |
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/metrics/Metric.java
Outdated
Show resolved
Hide resolved
apoorva918
reviewed
Feb 23, 2024
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/metrics/PravegaClient.java
Outdated
Show resolved
Hide resolved
windows-service/PscWatchdogApp.xml
Outdated
| <env name="PSC_SERVICE_NAME" value="PravegaSensorCollector" /> | ||
|
|
||
| <onfailure action="restart"/> | ||
| </service> |
There was a problem hiding this comment.
Please add newline here
pravega-sensor-collector/src/main/java/io/pravega/sensor/collector/file/FileIngestService.java
Show resolved
Hide resolved
Signed-off-by: Abhin Balur <[email protected]>
Signed-off-by: Abhin Balur <[email protected]>
Signed-off-by: Abhin Balur <[email protected]>
Fixing FileIngestServiceUnitTest
Fixing unable to load KeyCLoak creds
Signed-off-by: Abhin Balur <[email protected]>
| * json string. | ||
| */ | ||
| public static String getMetricsAsJson() throws JsonProcessingException { | ||
| ObjectMapper mapper = new ObjectMapper(); |
There was a problem hiding this comment.
Can you please make this variable static, so that it will not created for each json convertion
Signed-off-by: Abhin Balur <[email protected]>
Signed-off-by: Abhin Balur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Introduces a simple watchdog functionality for Pravega Sensor Collector.
Purpose of the change
Fixes #46
What the code does
Watchdog service looks for liveness of Pravega Sensor Collector and attempts to keep it up and running if not live.
The definition(can be extended with time) of liveness is watchdog looking for regular/live updates on a configured file made by PSC. If and when not live, Watchdog restarts PSC service as a corrective measure. There could be other corrective measures added in future.
How to verify it
Documentation to be updated.