Integration test #49
Merged
Integration test #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...lector/src/test/java/io/pravega/sensor/collector/PravegaSensorCollectorIntegrationTests.java
Outdated
Show resolved
Hide resolved
...lector/src/test/java/io/pravega/sensor/collector/PravegaSensorCollectorIntegrationTests.java
Outdated
Show resolved
Hide resolved
...lector/src/test/java/io/pravega/sensor/collector/PravegaSensorCollectorIntegrationTests.java
Outdated
Show resolved
Hide resolved
...lector/src/test/java/io/pravega/sensor/collector/PravegaSensorCollectorIntegrationTests.java
Outdated
Show resolved
Hide resolved
abhinb
reviewed
Feb 6, 2024
...lector/src/test/java/io/pravega/sensor/collector/PravegaSensorCollectorIntegrationTests.java
Outdated
Show resolved
Hide resolved
… updated test cases to reduce wait time. Signed-off-by: dada-dell-emc <[email protected]>
Signed-off-by: dada-dell-emc <[email protected]>
krishan-Rai
reviewed
Feb 13, 2024
| long getDeleteCompletedFilesIntervalInMinutes() { | ||
| return Long.parseLong(getProperty(DELETE_COMPLETED_FILES_INTERVAL_IN_MINUTES_KEY, "720")); | ||
| long getDeleteCompletedFilesIntervalInSeconds() { | ||
| return Long.parseLong(getProperty(DELETE_COMPLETED_FILES_INTERVAL_IN_SECONDS_KEY, "43200")); |
There was a problem hiding this comment.
is it like are we trying to delete completed file every 12 hours? @dada-dell-emc
| @@ -13,11 +13,12 @@ commonsCLIVersion=1.4 | |||
| commonsCSVVersion=1.8 | |||
| commonsCodecVersion=1.14 | |||
| commonsMath3Version=3.6.1 | |||
| grizzlyVersion=3.1.3 | |||
| grizzlyVersion=2.35 | |||
There was a problem hiding this comment.
why we are going to lower version here @dada-dell-emc ?
There was a problem hiding this comment.
Because of higher version there is conflicting versions dependency on glassfish library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Added end to end integration test case for PSC.
Purpose of the change
Test PSC functionality end to end integrating with Pravega using ingestion files no mock.
What the code does
It start pravega related services at the start of test setup, after that as a part of test case testRawFile it copies test ingestion files into respective directory from where PSC reads it and sends data to pravega. Test case checks that after 40-50 secs from start does database updates with completed files, if it does, then it waits another 50 secs to execute delete completed files tasks, once that wait is over test case checks completed files records from DB got deleted or not. This tests end to end PSC functionality.
How to verify it
Run all or particular test case(i.e. PravegaSensorCollectorIntegrationTests.testRawFile), it passes every time with in 1.5-2 mins.
What tests you have run. (Manually, automated whatever). How can someone else test this?
Follow steps mentioned above.