Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub checks #52

Conversation

Amit-Singh40
Copy link

@Amit-Singh40 Amit-Singh40 commented Feb 8, 2024

Test PR

Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
@Amit-Singh40 Amit-Singh40 marked this pull request as draft February 8, 2024 09:50
@Amit-Singh40 Amit-Singh40 marked this pull request as ready for review February 8, 2024 09:52
@Amit-Singh40 Amit-Singh40 marked this pull request as draft February 8, 2024 09:53
Signed-off-by: Amit-Singh40 <[email protected]>
@Amit-Singh40 Amit-Singh40 reopened this Feb 9, 2024
@Amit-Singh40 Amit-Singh40 marked this pull request as ready for review February 9, 2024 05:03
@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
@Amit-Singh40 Amit-Singh40 reopened this Feb 9, 2024
Signed-off-by: Amit-Singh40 <[email protected]>
@Amit-Singh40 Amit-Singh40 reopened this Feb 9, 2024
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
@sachin-j-joshi sachin-j-joshi changed the title Karman 10882 enable GitHub checks Enable GitHub checks Feb 9, 2024
Copy link
Contributor

@sachin-j-joshi sachin-j-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick comment

target: 80%
ignore:
- "**/generated/**"
- "standalone"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this relevant?
Also does this open up possibility of concentrating on specific subdirectories?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sachin, This not final PR. just created PR for testing purpose.

Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants