Enabling github checks #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Amit-Singh40
requested review from
sachin-j-joshi,
dada-dell-emc,
abhinb and
kuldeepk3
sachin-j-joshi
merged commit ab8f388
into
pravega:stability-improvements-v2
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
Enabling checks for unit test. checkstyle and spot bugs
Purpose of the change
Enables checks for unit test. checkstyle and spot bugs
What the code does
Enabling checks for unit tests. If unit test/spot bugs fails then build fails. It also runs the check styles but ignores the failures.
How to verify it
We can see the checks while raising the PR