Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karman 11833 fix spotbugs and checkstyle #59

Conversation

Amit-Singh40
Copy link

Change log description
Fixing checkstyle errors for main and test

Purpose of the change
To fix the checkstyle errors

What the code does
Fixes checkstyle errors

How to verify it.
Run checkstyle and spotbugs command

Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
Signed-off-by: Amit-Singh40 <[email protected]>
@Amit-Singh40 Amit-Singh40 marked this pull request as draft February 20, 2024 15:41
@Amit-Singh40 Amit-Singh40 marked this pull request as ready for review February 23, 2024 11:15
Copy link
Contributor

@kuldeepk3 kuldeepk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dada-dell-emc dada-dell-emc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhinb abhinb merged commit 02bbe17 into pravega:stability-improvements-v2 Mar 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants