Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit test for coverage #61

Conversation

kuldeepk3
Copy link
Contributor

@kuldeepk3 kuldeepk3 commented Feb 20, 2024

Change log description
Adding unit test for coverage.

Purpose of the change
Improvement of code coverage.

What the code does?
Adds unit tests to improve code coverage

How to verify it
Building the project will gives improved coverage

Copy link
Contributor

@sachin-j-joshi sachin-j-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please introduce a base class to avoid duplication of code.

@kuldeepk3
Copy link
Contributor Author

updated pr and removed unwanted code

Copy link
Contributor

@sachin-j-joshi sachin-j-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhinb abhinb merged commit 1e6d748 into pravega:stability-improvements-v2 Feb 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants