Adding validation for required parameters #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuldeepk3
changed the title
dada-dell-emc
approved these changes
Mar 6, 2024
abhinb
approved these changes
Mar 6, 2024
Signed-off-by: Kuldeep Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log description
PSC_ID has been made a mandatory parameter to be updated in the PravegaSensorCollector.xml , which is used by watchdog process to monitor running psc.
Purpose of the change
Update mandatory field while executing psc.
What the code does?
Adds validation for mandatory field PSC_ID.
How to verify it
PSC service should not start if the value for key PSC_ID in the configurable xml file is absent or if the parameter itself is missing.
Starting watchdog service should fail if PSC service is not running.