Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating READMe file #68

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

kuldeepk3
Copy link
Contributor

Change log description
Update README to include new field for paramaters table. The new field tells user whether the parameter is optional or mandatory for running psc service

Purpose of the change
Update optional / mandatory fields.

What the code does?
Adds new column in readme to denote mandatory/optional parameter.

How to verify it
Update parameter file (PravegaSensorCollector.xml) as per the parameters table and psc should run without error.

@kuldeepk3 kuldeepk3 marked this pull request as ready for review March 6, 2024 04:29
Copy link
Contributor

@dada-dell-emc dada-dell-emc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-j-joshi sachin-j-joshi merged commit cf0cc0a into pravega:watchdogv1 Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants