Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making file extension mandatory #69

Merged

Conversation

kuldeepk3
Copy link
Contributor

Change log description
File extension is optional parameter but when we try to process parquet file using CsvFileIngestService class, it throws parsing error when it tries to process parquet file.

Purpose of the change
Fixes error while processing parquet file while using CsvFileServiceIngestService

What the code does?
Makes FILE_EXTENSION mandatory field.

How to verify it
PSC service should start without error and respective drivers should be able to process respective file extension without error and move files with different extensions to failed files folder.

Copy link
Contributor

@dada-dell-emc dada-dell-emc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sachin-j-joshi sachin-j-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sachin-j-joshi sachin-j-joshi merged commit c802447 into pravega:watchdogv1 Mar 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants