onboarding: request level timeouts #189
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
references #164 (comment) cc @grod220
based on offline discussion with @turbocrime, the channel transport has default 60 second timeout, and grpc web transport have no timeout. The channel transport timeout is insufficient for our needs, as we may need to cycle through multiple rpcs to request the block height during onboarding. Instead, we’ve implemented a more granular request-level timeout of 5 seconds directly within the fetch request.