Clear password in memory (settings page) #63
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Settings page, after submitting their password to reveal their seed phrase
This PR sets the react state to an empty string if successful. That way, when the seed phrase is revealed, the users plain text password is not still in memory.
It is quite the edge case (given memory is flushed every time someone clicks away from the popup), but auditors feel it's best to clear it manually as extracting plain text passwords have security implications for the user outside of Prax.