Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear password in memory (settings page) #63

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented Jun 26, 2024

Context: Settings page, after submitting their password to reveal their seed phrase

This PR sets the react state to an empty string if successful. That way, when the seed phrase is revealed, the users plain text password is not still in memory.

It is quite the edge case (given memory is flushed every time someone clicks away from the popup), but auditors feel it's best to clear it manually as extracting plain text passwords have security implications for the user outside of Prax.

Copy link

changeset-bot bot commented Jun 26, 2024

⚠️ No Changeset found

Latest commit: 46e26b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@grod220 grod220 requested a review from a team June 26, 2024 13:03
@grod220 grod220 merged commit 402cd2f into main Jun 26, 2024
3 checks passed
@grod220 grod220 deleted the clear-password-in-mem branch June 26, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants